Fix for #64: return before error on missing fields #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rachsmithcodes: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
rachsmithcodes
changed the title
| @@ -175,7 +175,7 @@ export function NoMissingClientDirectives(context: ValidationContext) { | |||
| const fieldDef = context.getFieldDef(); | |||
|
|
|||
| // if we don't have a type to check then we can early return | |||
| if (!parentType) return; | |||
| if (!parentType || fieldDef) return; | |||
There was a problem hiding this comment.
Perhaps reverse the check on fieldDef here? !fieldDef
There was a problem hiding this comment.
Agree it looks like we need to flip this condition, went ahead and made that change in 9d95cac
alessbell
force-pushed
the
fix-validation-missing-fields
branch
from
78e9cc4
to
552dba3
Compare
|
Fixed broken test in a follow-on commit: bf80011 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting the error described in #64.
As far as I can tell, it is happening in when a GraphQL document includes a field that doesn't exist on the server schema. In this scenario the validation should add an error like this:
But when it gets run though the
NoMissingClientDirectivesrule,context.getFieldDef()returnsundefined, causing the extension to error on line 103 ofvalidation.js.Adding an early return if the
fieldDefdoesn't exist prevents the error.┆Issue is synchronized with this Jira Task by Unito