fix regex for ruby heredoc #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jgzuke, I forgot about this PR since I'm apparently still running a forked version of the extension. Someone on my team pointed out they're still having this issue. Any chance I can get you or one of the other maintainers to give this a review when you get a chance? |
|
Hi! I no longer work on this project, @cy maybe? |
|
@martijnwalraven are you a still a maintainer? |
alessbell
force-pushed
the
fix-ruby-heredoc
branch
from
6caa4e0
to
6e8e652
Compare
|
Hi @jtgrenz 👋 Doing some maintenance and will be merging this imminently - thanks for your patience! |
alessbell
approved these changes
Oct 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
I ran into this issue where the syntax highlighting got all borked when ApolloGraphQL was installed but noticed that other extensions were working fine. For example: https://github.com/kumarharsh/graphql-for-vscode/blob/master/syntaxes/graphql.rb.json. This PR uses the same regex which seems to resolve the issue.
First time contributing here, so let me know if theres anything else needed to merge this.
┆Issue is synchronized with this Jira Task by Unito