This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Update apollo-client, increase performance, and pass polling props #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaxleyiii
changed the title
| Feature: add `startPolling` and `stopPolling` to the prop object for queries | ||
| Bug: Fix bug where full options were not being passed to watchQuery | ||
|
|
||
| ### v0.3.1 |
There was a problem hiding this comment.
Why two separate versions?
There was a problem hiding this comment.
0.3.1 was already published but not updated in the changelog
jbaxleyiii
changed the title
jbaxleyiii
changed the title
|
@stubailo this should be good to go. If you are good with it, feel free to merge. It'll deploy on its own |
jbaxleyiii
changed the title
| @@ -1,9 +1,9 @@ | |||
| declare module "lodash.isobject" { | |||
| import main = require('~lodash/index'); | |||
| export = main.isObject; | |||
| // export = main.isObject; | |||
|
Looks good to me! Only thing is I'm not sure what's with the commented typings. |
|
Oh yeah! I upgraded my typings locally. I think it was seeing ambient.d.ts and the generated files. I'm not really sure, need to investigate more |
|
|
looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings support for polling with the client as well as passes
stopPollingandstartPollingto the client.It also adds a check to prevent rerenders if the data doesn't change.