Extension for sorting projects/environments #19
Conversation
| * @throws GemException if more than one sorter is provided. | ||
| */ | ||
| public default IGemSorter getGemSorter() { | ||
| final Collection<IGemSorter> sorters = getGemServices(IGemSorter.class); |
There was a problem hiding this comment.
Why a Collection and not a List (or Set)?
There was a problem hiding this comment.
The API for getGemServices is already returning a collection; this change is not refactoring that API but just using it. I believe that it is because the implementation of the IServiceContainer is using Map::values to return the services. In any case, as the services are used mostly internally to provide hooks on GEM, it shouldn't be a problem and we can always change between collection implementations as required.
| */ | ||
| @Override | ||
| public default String getName() { | ||
| return getId(); |
There was a problem hiding this comment.
Is it correct that both method call getId?
There was a problem hiding this comment.
For the gem-sorter, the name and display name are irrelevant by now cause only one should be provided and it is not used out of the core plug-in. In case that we allow in the future several sorters and a way to switch between them this should be reverted and each of the sorters should provide its own implementation of this methods (thus, removing the default one on the interface).
Type of request
Related Issue(s)
Closes #18
Checklist: