Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting future to default as false #20

Conversation

blaineo
Copy link

@blaineo blaineo commented Feb 1, 2018

This will set the future variable to false. I don't see any recourse.
It helps reduce required request variables when using this module in combination with apostrophe-headless and this module.

If this does cause an unforeseen issue, I have yet to encounter it.

Without this change requests to the api require a future param:
/api/v1/apostrophe-blog?future=false/true

With this change, the base url will return blog articles not in the future with:
/api/v1/apostrophe-blog

@blaineo blaineo changed the title chore(setting future to default as false ) setting future to default as false Feb 1, 2018
@boutell
Copy link
Contributor

boutell commented Feb 5, 2018 via email

@abea
Copy link
Contributor

abea commented May 12, 2020

@boutell Did you ever get a chance to review in apos-headless?

@abea abea closed this Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants