modification indicator implemented #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also replaced CSS and data attribute names such as apos-site-review with apos-review, as the module was renamed apostrophe-review-and-deploy, removing the redundant "site-" prefix (Apostrophe is always about sites and has a no-redundant-naming policy). |
boutell
commented
Jan 12, 2018
index.js
Outdated
| var ids = self.apos.launder.ids(req.body.ids); | ||
| return self.getLastDeployedReview(req) | ||
| .then(function(deployed) { | ||
| return Promise.map(ids, function(id) { |
There was a problem hiding this comment.
Hey doofus, what if deployed doesn't exist?
plantainrain
approved these changes
Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.