Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc improvements #1

Merged
merged 5 commits into from
Apr 29, 2024
Merged

doc improvements #1

merged 5 commits into from
Apr 29, 2024

Conversation

ETLaurent
Copy link
Contributor

@ETLaurent ETLaurent commented Apr 24, 2024

  • improve doc
  • add format via register function
  • use the first sheet as we don't know its name

@ETLaurent ETLaurent changed the title Tom improvements Apr 24, 2024
@ETLaurent ETLaurent requested a review from boutell April 24, 2024 16:11
@ETLaurent ETLaurent marked this pull request as ready for review April 24, 2024 16:11
@ETLaurent ETLaurent changed the title improvements doc improvements Apr 24, 2024
README.md Outdated
@@ -37,10 +43,11 @@ Configure the module in the `app.js` file:
require('apostrophe')({
shortName: 'my-project',
modules: {
'@apostrophecms/import-export': {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma

lib/xlsx.js Outdated Show resolved Hide resolved
@ETLaurent ETLaurent requested a review from boutell April 29, 2024 09:37
@ETLaurent ETLaurent merged commit 2e09652 into main Apr 29, 2024
9 checks passed
@ETLaurent ETLaurent deleted the tom branch April 29, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants