Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid podman arguments in makefile #3652

Open
mshriver opened this issue Jul 6, 2023 · 3 comments
Open

Invalid podman arguments in makefile #3652

mshriver opened this issue Jul 6, 2023 · 3 comments

Comments

@mshriver
Copy link

mshriver commented Jul 6, 2023

The Makefile includes automatic use of podman, but includes an option that is not accepted by podman.

https://github.com/app-sre/qontract-reconcile/blob/master/Makefile#L68

This argument is not valid for podman:

--add-host=host.docker.internal:host-gateway

And creates the following failure mode when dev-reconcile-loop is used:

Error: invalid IP address in add-host: "host-gateway"

Currently playing with what would be valid arguments for podman runtime. It ties into qontract-server makefile as well, since that runs the server with direct port bindings. Maybe both using an expected podman network would be a preferable solution, although it looks like the argument isn't needed at all when running in podman, or the --network host argument can be used.

@maorfr
Copy link
Contributor

maorfr commented Jul 6, 2023

@maorfr
Copy link
Contributor

maorfr commented Jul 9, 2023

fwiw, you can pip install qontract-reconcile

@mshriver
Copy link
Author

@maorfr yeah but I'm trying to break it and be a PITA and use podman 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants