enable resource resolution on jenkins-config.config_path #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoberle
added a commit
to geoberle/qontract-reconcile
that referenced
this pull request
Jul 15, 2022
the jenkins job builder integration loads config_path resources one by one which results in slower reconciliation runs. to improve that, we use the resource reference resolver feature from qontract-server introduced with app-sre/qontract-server#147 while the impact on integration speed is not that hight for jenkins job builder, the resource resolution capability can be easily showcased on this integration so others like terraform-resources have a working example part of https://issues.redhat.com/browse/APPSRE-6003 depends on schema change app-sre/qontract-schemas#190 Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
this enables writing queries for jenkins_config config_path like
```
{
jenkins_configs: jenkins_configs_v1 {
name
...
type
config
config_path {
content
sha256sum
}
}
}
```
part of https://issues.redhat.com/browse/APPSRE-6003
follows up on https://issues.redhat.com/browse/APPSRE-5950
Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
geoberle
force-pushed
the
jenkins-config-resource-resolution
branch
from
27bf4c8
to
992b208
Compare
geoberle
added a commit
to app-sre/qontract-reconcile
that referenced
this pull request
Jul 15, 2022
the jenkins job builder integration loads config_path resources one by one which results in slower reconciliation runs. to improve that, we use the resource reference resolver feature from qontract-server introduced with app-sre/qontract-server#147 while the impact on integration speed is not that hight for jenkins job builder, the resource resolution capability can be easily showcased on this integration so others like terraform-resources have a working example part of https://issues.redhat.com/browse/APPSRE-6003 depends on schema change app-sre/qontract-schemas#190 Signed-off-by: Gerd Oberlechner <goberlec@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enables writing queries for jenkins-config-1.config_path like
part of https://issues.redhat.com/browse/APPSRE-6003
follows up on https://issues.redhat.com/browse/APPSRE-5950
Signed-off-by: Gerd Oberlechner goberlec@redhat.com