search v2 #12
Open
search v2 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2024 22:23
| @@ -27,7 +27,7 @@ | |||
| ], | |||
| "require": { | |||
| "ext-json": "*", | |||
| "php": "^7.3|^8.0" | |||
There was a problem hiding this comment.
Why is the requirement for PHP 8 in this update?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KvK search api v1 will end from 29th of July, so not available for use anymore. Only v2 will be its replacement. I adjusted the code to adopt the v2 search api. The main thing is the change in the address in the response. Address is from now on an object in the response, either of type BinnenlandAdres or Buitenlandadres. I adjusted the SearchMapper to return either a BinnenlandAdres or BuitenlandAdres object.