fix(tag mode): strict selection behavior to only allow picking from suggestions #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthlatest
changed the title
Comment on lines
598
to
604
| if (props.strictSelection && props.autosuggest) { | ||
| if (cause === causes.SUGGESTION_SELECT || props.value !== undefined) { | ||
| this.updateQueryHandler(props.componentId, queryHandlerValue, props); | ||
| } else if (this.currentValue !== '') { | ||
| } else if (this.currentValue !== '' && !props.strictSelection) { | ||
| this.setValue('', true); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
:598 already checks for strictSelection prop which makes the check for strictSelection at L:608 unreachable
There was a problem hiding this comment.
I'm not seeing a check that would make it unreachable. At L598, the check is for isTagsMode
Comment on lines
+814
to
+817
| this.isSuggestionSelected = true; | ||
| setTimeout(() => { | ||
| this.isSuggestionSelected = false; | ||
| }, 50); |
There was a problem hiding this comment.
@siddharthlatest Can you explain the reason for async toggle of isSuggestionSelected?
There was a problem hiding this comment.
This fixes a side effect I am observing with two calls being made to this.setValue otherwise. See the use of the variable for the second place where the second call is being made from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a behavior for tag mode where a user setting an input value that is not part of suggestions is not allowed when
strictSelectionmode is set.Components this applies to:
For code review, the main changes are in the first two commits: DataSearch code change, SearchBox code change
This change is available in
reactivesearch-vuev1.35.3. The changes in this PR should be cherry-picked to Vue v3 version and React v4 versions.