Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #371 resetting page number on sort change #372

Merged
merged 3 commits into from
May 19, 2018
Merged

Fix issue #371 resetting page number on sort change #372

merged 3 commits into from
May 19, 2018

Conversation

a-magdy
Copy link
Contributor

@a-magdy a-magdy commented May 18, 2018 •
edited
Loading

Fix for #371

  • Update ReactiveList handleSortChange
    • Send the options.from = 0
    • setState({ from: 0, currentPage: 0 }) setting the correct page in the state, and force re-render the correct pagination with the first page selected

@a-magdy a-magdy mentioned this pull request May 18, 2018
Closed
@a-magdy
Update ReactiveList handleSortChange by setState {currentPage:0,from=…
0f5999b 
…0} to set the new correct values for pages

and force re-render the pages when pagination=true
@metagrover metagrover self-assigned this May 19, 2018
@metagrover metagrover merged commit d2d1139 into appbaseio:dev May 19, 2018
@metagrover
Copy link
Contributor

@a-magdy Thank you for contributing 🎉

We will roll this out in the upcoming release.

@zvictor zvictor deleted the fix-issue-371-reset-page-number-on-sort branch November 10, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metagrover metagrover metagrover approved these changes

Assignees

@metagrover metagrover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-magdy @metagrover