This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
common: add additional docker informations to manifest. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
force-pushed
the
add_docker_v1_annotations
branch
from
e47fc74
to
6eb9f28
Compare
| AppcDockerV1Repository = "appc.io/docker/v1/repository" | ||
| AppcDockerV1Tag = "appc.io/docker/v1/tag" | ||
| AppcDockerV1ImageID = "appc.io/docker/v1/imageid" | ||
| AppcDockerV1ParentImageID = "appc.io/docker/v1/parentimageid" |
There was a problem hiding this comment.
I was thinking to export them for use by rkt but this doesn't make much sense. I'll make them unexported.
sgotti
force-pushed
the
add_docker_v1_annotations
branch
from
6eb9f28
to
8eff8a1
Compare
|
Just a small nit, can you Then it's good to merge. |
sgotti
force-pushed
the
add_docker_v1_annotations
branch
from
8eff8a1
to
be3dd75
Compare
|
@iaguis sure thanks! What do you think about the names (for example |
|
Hmm... now that you mention it I think we should use |
This adds additional docker information to the image manifest. Now the v1 registry information are added under the `appc.io/docker/v1/` namespace: `appc.io/docker/v1/indexurl` `appc.io/docker/v1/repository` `appc.io/docker/v1/tag` `appc.io/docker/v1/imageid` `appc.io/docker/v1/parentimageid`
sgotti
force-pushed
the
add_docker_v1_annotations
branch
from
be3dd75
to
60c1d27
Compare
|
Done! |
|
Cool. Thanks! |
iaguis
added a commit
that referenced
this pull request
Aug 10, 2015
common: add additional docker informations to manifest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tries to implement the idea from #15.
This adds additional docker informations to the image manifest.
Now the v1 registry informations are added under the
appc.io/docker/v1/namespace:
appc.io/docker/v1/indexurlappc.io/docker/v1/repositoryappc.io/docker/v1/tagappc.io/docker/v1/imageidappc.io/docker/v1/parentimageidBefore adding a WELLKNOWN.md like proposed I'd like to get suggestions on the annotation names. For example
indexurlshould beregistryurl?This can be useful for getting docker v1 caching infos like proposed in rkt/rkt#1196 (comment) without the need to save the imageID info in a store sql table.