Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(android): update examples and add material theme #86

Merged
merged 4 commits into from Sep 28, 2020
Merged

refactor(android): update examples and add material theme #86

merged 4 commits into from Sep 28, 2020

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Aug 19, 2020 •
edited

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27714

Note:
These changes will work on Titanium 9.0.0 and higher.

Summary:

  • Updated to use Google's material theme.
  • Updated "Bottom Navigation View" example:
    • Now shows how to add a badge number to a tab. (Requires material theme.)
    • Fixed tab selection. Tapping a tab will now highlight it.
  • Updated "Blur" example:
    • Now blurs an image instead of lines.
    • Shows a "Blur" and "Unblur" button like iOS. (For showing before/after.)
  • Updated "Touches" example:
    • Fixed touch dragging a square. (Never worked before.)
    • Made squares bigger to make them easier to drag.

Screenshots:
HyperloopBlurBefore HyperloopBlurAfter
HyperloopBottomNavView HyperloopTouches

@jquick-axway jquick-axway mentioned this pull request Aug 19, 2020
Closed
@ssjsamir ssjsamir self-requested a review September 28, 2020 13:33
ssjsamir
ssjsamir approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy sgtcoolguy merged commit 614e83c into tidev:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssjsamir ssjsamir ssjsamir approved these changes

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @ssjsamir @sgtcoolguy