chore(iOS): update for Titanium 10.0.1 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
requested changes
May 24, 2021
There was a problem hiding this comment.
Tested across iOS (using tidev/titanium-sdk/pull/12829) and Android, looks good!
Just one comment on the ios/gravity example where it looks like the import has changed
|
FR Passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28458
Summary:
2DMatrixwithMatrix2D.UILocalNotification.Note:
This app will crash on startup on iOS due to a Titanium 10.0.0 regression with the
Hyperloop.defineClass()method. Will be fixed by the following PR to be fixed in Titanium 10.0.1.tidev/titanium-sdk#12829