Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24837] Fixed handling of sim runtimes that are associated to m… #63

Merged
merged 2 commits into from Jun 16, 2017

Conversation

cb1kenobi
Copy link
Contributor

[TIMOB-24837] Fixed handling of sim runtimes that are associated to multiple iOS SDKs and fixed a bug where the oldest Xcode was always autoselected.

https://jira.appcelerator.org/browse/TIMOB-24837

…ultiple iOS SDKs and fixed a bug where the oldest Xcode was always autoselected.
Copy link

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed! Just left a small note regarding a typo in a comment.

lib/simulator.js Outdated

// This code finds the sim runtime and builds the list of associated
// iOS SDKs which may be different based which Xcode's simctl is run.
// For example, sim runtime 8.3 is associated with iOS 10.3 and 10.3.1.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably mean sim runtime 10.3?

@cb1kenobi cb1kenobi self-assigned this Jun 16, 2017
@janvennemann janvennemann merged commit 80bdfd6 into master Jun 16, 2017
@cb1kenobi cb1kenobi deleted the timob-24837 branch June 16, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants