[TIMOB-23748] Failed to connect to WP 8.1 device #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // From some point of Windows 10 SDK, IDevice.GetEndPoints throws Exception for Windows Phone 8.1 device. | ||
| // Returning ok for now because we can still connect to the device. | ||
| // | ||
| if (command == "connect" && connectableDevice.Version.Major == 8 && !connectableDevice.IsEmulator()) { |
There was a problem hiding this comment.
Note: Interestingly I've seen ConnectableDevice.Version returns 8.1 or 6.3 with the updated SDK. This may not be quite expected before as we have been seeing it returns 6.3 for Windows Phone 8.1 device.
|
@infosia Since this is the same problem for Windows 10 devices wptool.cs#L179 we could remove the Windows 10 |
|
@garymathews Yeah makes sense. I would remove the Windows 10 |
|
CR: PASS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-23748
Titanium CLI is unable to connect to Windows Phone 8.1 device after updating to Microsoft Windows 10 SDK
10.0.14393. There's no problem building against Windows 10 Mobile device though.As far as I can see, it turns out that
Microsoft.SmartDevice.Connectivity.IDevice.GetEndPointsthrows Exception when you connect to Windows Phone 8.1 device. I found that it actually is able to connect to WP 8.1 device, and those information (thatIDevice.GetEndPointscollects) are not actually used from Titanium CLI, so it's safe to return success=true.