Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimize snapshots retrieval and caching logic #393

Merged
merged 5 commits into from
Oct 9, 2020

Conversation

mykola-mokhnach
Copy link

No description provided.

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🎉

*/
- (nullable XCUIElement *)elementForUUID:(NSString *__nullable)uuid;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if (element.query.fb_isSnapshotsCachingSupported && nil == element.fb_cachedSnapshot && ![element fb_nativeResolve]) {
isStale = YES;
}
if (isStale || nil == element) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mykola-mokhnach mykola-mokhnach merged commit bceb415 into master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants