Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support prebuiltWDAPath for iOS 17 #868

Merged
merged 6 commits into from
Mar 23, 2024
Merged

feat: Support prebuiltWDAPath for iOS 17 #868

merged 6 commits into from
Mar 23, 2024

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Mar 22, 2024

closes appium/appium#19206 (comment)

This method requires WDA package that DOES NOT have Frameworks/XC** in the WDA package.
The configuration is the same as what users can get via https://github.com/appium/WebDriverAgent/releases

With the XC***, the WDA app launches successfully but the app ends immediately because testmanagerd process fails to start. Potentially we can avoid this limitation when our appium-ios-device gets the new protocol, or 3rd party tools. (I haven't tested)

Tested with:

  • appium:usePreinstalledWDA
  • appium:updatedWDABundleId
  • appium:prebuiltWDAPath

I'll update https://appium.github.io/appium-xcuitest-driver/latest/guides/run-preinstalled-wda/ page as well later.

@KazuCocoa KazuCocoa changed the title feat: add a method to launch wda via devicectl feat: Support prebuiltWDAPath for iOS 17 Mar 22, 2024
@KazuCocoa
Copy link
Member Author

updated

@KazuCocoa KazuCocoa merged commit 39194d4 into master Mar 23, 2024
46 checks passed
@KazuCocoa KazuCocoa deleted the launch-wda branch March 23, 2024 18:34
github-actions bot pushed a commit that referenced this pull request Mar 23, 2024
## [7.3.0](v7.2.0...v7.3.0) (2024-03-23)

### Features

* Support prebuiltWDAPath for iOS 17 ([#868](#868)) ([39194d4](39194d4))
Copy link

🎉 This PR is included in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yehe01
Copy link

yehe01 commented Jun 4, 2024

This approach doesn't seem to work for simulators. iOS 17.0 Xcode 15.0

The wda crashes upon launch:

Screenshot 2024-06-05 at 12 15 25 AM

@KazuCocoa
Copy link
Member Author

This change is mostly for real devices. For simulators, it might work with an app built on the same machine. I haven't dug into details for simulators.

@yehe01
Copy link

yehe01 commented Jun 4, 2024 via email

@KazuCocoa
Copy link
Member Author

Well, for the docs, https://appium.github.io/appium-xcuitest-driver/latest/guides/run-preinstalled-wda/#additional-requirement-for-ios-17tvos17 is for xcrun devicectl device process launch which is for real devices. It may need to address it is only for real devices.

The sim support was added after a while, so some may need to adjust for simulators. I haven't dug into simulator cases so the docs still need to be updated for simulators I believe. It is appreciated to create a PR to improve the docs if you learn new things. We basically update docs when we learn, so it might not be perfect for all cases since it is leaning-basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usePreinstalledWDA=true does not work with iOS 17 (Xcode 15)
3 participants