Accept SSL certs #10
Merged
Accept SSL certs #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is something wrong in the e2e tests. Can you run them locally to check that they work? Also, the commits ought to be squashed, as they are all a single logical addition. Thanks for this work! |
ngsankha
force-pushed
the
acceptSSLCerts
branch
2 times, most recently
from
053a8cb to
0fb8aa8
Compare
ngsankha
force-pushed
the
acceptSSLCerts
branch
from
0fb8aa8 to
69b1212
Compare
|
@imurchie All tests passed and also squashed into a single commit. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto accept the invalid SSL certificate errors.