This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
fix: Patch downstream responses for unknown upstream protocol #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Aug 31, 2019
| @@ -199,6 +212,11 @@ class ProtocolConverter { | |||
| */ | |||
| async convertAndProxy (commandName, url, method, body) { | |||
| if (!this.downstreamProtocol) { | |||
| if (commandName === 'getStatus') { | |||
| // Patch getStatus call for GENERIC protocol | |||
There was a problem hiding this comment.
There are existing tests, I would say they do cover such changes
dpgraham
approved these changes
Sep 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the idea is to add
statusandsessionIdfields to getStatus responses if the call was made before session creation request has been sentAddresses appium/appium#13161