This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
fix: make sure the listener gets removed after the command executor is completed #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
approved these changes
Nov 26, 2019
jlipps
reviewed
Nov 26, 2019
lib/basedriver/driver.js
Outdated
| this.eventEmitter.on(ON_UNEXPECTED_SHUTDOWN_EVENT, unexpectedShutdownListener); | ||
| }) | ||
| ]).finally(() => { | ||
| // https://github.com/appium/appium/issues/13631 |
There was a problem hiding this comment.
in general, IMO a comment which is only a link is not as useful as one which briefly explains something in words and then also includes a link.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address appium/appium#13631 (comment)