Using container ip address #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ if [ -z "$PLATFORM_NAME" ]; then | |||
| fi | |||
|
|
|||
| if [ -z "$APPIUM_HOST" ]; then | |||
| APPIUM_HOST="127.0.0.1" | |||
| APPIUM_HOST=$(hostname -i) | |||
There was a problem hiding this comment.
-i, --ip-address
Display the IP address(es) of the host. Note that this works only if the host name can be resolved. Avoid using this option; use hostname --all-ip-addresses instead.
Is it safe?
There was a problem hiding this comment.
There was a problem hiding this comment.
The script will run inside container and It will give the IP address of that running container so I think it should be fine.
There was a problem hiding this comment.
I think it should be fine
SrinivasanTarget
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses container IP address so that container do not need to run in the same network where docker-selenium hub is running.