fix: use displayManager.getDisplay only for upcoming androidx.test.uiautomator:uiautomator:2.3.0-beta01 #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…automator:uiautomator:2.3.0-beta01
mykola-mokhnach
approved these changes
Dec 30, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2023
## [5.15.2](v5.15.1...v5.15.2) (2023-12-30) ### Bug Fixes * use displayManager.getDisplay only for upcoming androidx.test.uiautomator:uiautomator:2.3.0-beta01 ([#588](#588)) ([61af265](61af265))
|
🎉 This PR is included in version 5.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A future compatibility fix in #490
It looks like androidx.test.uiautomator.UiDevice in 2.3.0-beta01 dropped
getDefaultDisplay, thus all versions should follow thedisplayManager.getDisplay(Display.DEFAULT_DISPLAY);way. The current master has no issue with the 2.2.0 version.The API itself has existed since API level 17 https://developer.android.com/reference/android/hardware/display/DisplayManager#getDisplay(int), thus this change should be safe. (I have tested with an Android 9 real device. It worked)
I have tested
displayManager.getDisplay(Display.DEFAULT_DISPLAY);works with Android 9 as well.