Throw error if carthage does not exist

[imurchie]

Otherwise we get difficult-to-discern errors in running the WebDriverScript. See, for instance, appium/appium#6853

[wfanforever]

This one caused me an issue that i have Carthage installed but it kept complaining that it didn;t. :(

[imurchie]

Can you post logs to it doing so? And information about your Carthage installation?

[wfanforever]

info iOSSim Simulator booted in 23839ms
info XCUITest Using default agent: /Users/wfan/appium/appium-xcuitest-driver/WebDriverAgent/WebDriverAgent.xcodeproj
info XCUITest Using default bootstrap: /Users/wfan/appium/appium-xcuitest-driver/WebDriverAgent
info XCUITest Launching WebDriverAgent on the device
ERR! XCUITest Error: Carthage not found. Install using `brew install carthage`
ERR! XCUITest     at Object.wrappedLogger.errorAndThrow (lib/logger.js:60:13)
ERR! XCUITest     at WebDriverAgent.checkForDependencies$ (lib/webdriveragent.js:101:11)
ERR! XCUITest     at tryCatch (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:67:40)
ERR! XCUITest     at GeneratorFunctionPrototype.invoke [as _invoke] (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:315:22)
ERR! XCUITest     at GeneratorFunctionPrototype.prototype.(anonymous function) [as throw] (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:100:21)
ERR! XCUITest     at GeneratorFunctionPrototype.invoke (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:136:37)
ERR! XCUITest     at run (/Users/wfan/appium/appium-xcuitest-driver/node_modules/core-js/library/modules/es6.promise.js:108:47)
ERR! XCUITest     at /Users/wfan/appium/appium-xcuitest-driver/node_modules/core-js/library/modules/es6.promise.js:119:28
ERR! XCUITest     at flush (/Users/wfan/appium/appium-xcuitest-driver/node_modules/core-js/library/modules/$.microtask.js:19:5)
ERR! XCUITest     at nextTickCallbackWith0Args (node.js:453:9)
ERR! XCUITest     at process._tickCallback (node.js:382:13)
ERR! XCUITest  [Error: Carthage not found. Install using `brew install carthage`]
ERR! XCUITest Error: Carthage not found. Install using `brew install carthage`
ERR! XCUITest     at Object.wrappedLogger.errorAndThrow (lib/logger.js:60:13)
ERR! XCUITest     at WebDriverAgent.checkForDependencies$ (lib/webdriveragent.js:101:11)
ERR! XCUITest     at tryCatch (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:67:40)
ERR! XCUITest     at GeneratorFunctionPrototype.invoke [as _invoke] (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:315:22)
ERR! XCUITest     at GeneratorFunctionPrototype.prototype.(anonymous function) [as throw] (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:100:21)
ERR! XCUITest     at GeneratorFunctionPrototype.invoke (/Users/wfan/appium/appium-xcuitest-driver/node_modules/babel-runtime/regenerator/runtime.js:136:37)
ERR! XCUITest     at run (/Users/wfan/appium/appium-xcuitest-driver/node_modules/core-js/library/modules/es6.promise.js:108:47)
ERR! XCUITest     at /Users/wfan/appium/appium-xcuitest-driver/node_modules/core-js/library/modules/es6.promise.js:119:28
ERR! XCUITest     at flush (/Users/wfan/appium/appium-xcuitest-driver/node_modules/core-js/library/modules/$.microtask.js:19:5)
ERR! XCUITest     at nextTickCallbackWith0Args (node.js:453:9)
ERR! XCUITest     at process._tickCallback (node.js:382:13)
ERR! XCUITest  [Error: Carthage not found. Install using `brew install carthage`]
info XCUITest Shutting down WebDriverAgent
dbug XCUITest Resetting simulator
dbug XCUITest Shutting down simulator
dbug iOSSim Killing all iOS Simulators
dbug iOSLog Stopping iOS log capture

which Carthage
/usr/local/bin/Carthage

[imurchie]

Hmm. Interesting.

Does your system respond the same way if you don't capitalize carthage? (I.e., which carthage)?

[wfanforever]

Yup. same result.

which carthage
/usr/local/bin/carthage

[imurchie]

And you're running Appium in the same way as you're running which carthage? From the command line, same user and all?

[wfanforever]

yeah, nothing changed. It worked fine without this commit.

[imurchie]

Alright. I'll change it to logging the information instead of erroring out. Though it makes no sense that it wouldn't be able to find it (since all this is doing is running which carthage). Alas.

[wfanforever]

Thanks! this should fix the issue :)