Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates and removals #200

Merged
merged 1 commit into from
Dec 10, 2017
Merged

Updates and removals #200

merged 1 commit into from
Dec 10, 2017

Conversation

TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Dec 9, 2017 •
edited
Loading

Change list

  • NuGet reference were updated:

    • Newtonsoft.Json was updated to 10.0.3
    • Selenium.Support was updated 3.8.0
    • Selenium.WebDriver was updated 3.8.0
    • Castle.Core was updated to 4.2.1

  • Resolving of compilation issues

  • Unnecessary interface ITouchShortcuts was removed.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

There has not been any update since Dec'16/Jan'17. So I hope it is the first step to the new enhanced version.

I decided to start with updates of references. It was enough to get it campiled and run some tests for the first time

@TikhomirovSergey
The starting of the project enhancement/improvement
d29042c 
- NuGet reference were updated:
  - Newtonsoft.Json was updated to 10.0.3
  - Selenium.Support was updated 3.8.0
  - Selenium.WebDriver was updated 3.8.0
  - Castle.Core was updated to 4.2.1

 - Resolving of compilation issues
 - Unnecessary interface ITouchShortcuts was removed.
SrinivasanTarget
SrinivasanTarget approved these changes Dec 10, 2017
View reviewed changes
Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mykola-mokhnach
mykola-mokhnach approved these changes Dec 10, 2017
View reviewed changes
Copy link

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in dotnet at all %)

@TikhomirovSergey TikhomirovSergey merged commit c3ea633 into appium:master Dec 10, 2017
@TikhomirovSergey TikhomirovSergey mentioned this pull request Dec 10, 2017
Closed
@lanzelot1989
Copy link
Contributor

Hi, when do you plan on publishing this on NuGet?

@siggerzz siggerzz mentioned this pull request Dec 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TikhomirovSergey @lanzelot1989 @mykola-mokhnach @SrinivasanTarget