Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AndroidMobileCapabilityType #1238

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Update AndroidMobileCapabilityType #1238

merged 5 commits into from
Sep 17, 2019

Conversation

a-en
Copy link
Contributor

@a-en a-en commented Sep 16, 2019

Change list

Added missing capabilities from docs to AndroidMobileCapabilityType interface. Also, this will fix this issue

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted java code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@jsf-clabot
Copy link

jsf-clabot commented Sep 16, 2019

CLA assistant check
All committers have signed the CLA.


/**
* Initializing the app under test automatically.
* Appium does not install/launch the app under test if this is {@code false}. Defaults to {@code true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does install the app, but skips the launch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach I've changed description to 'Appium does not launch the app...'. Should it be also changed in http://appium.io/docs/en/writing-running-appium/caps/ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it makes sense to update the description in the documentation

@mykola-mokhnach
Copy link
Contributor

Thanks. It might also be useful to mention since which Appium version these caps are available. (aka @since doc option)

@a-en
Copy link
Contributor Author

a-en commented Sep 17, 2019

@mykola-mokhnach I've went through releases of Appium on github and collected since for those caps I was able to find. Are there any other sources that might be used to add this information?

@mykola-mokhnach
Copy link
Contributor

Usually version changelist is the only source to find it out

@SrinivasanTarget SrinivasanTarget merged commit e19ac64 into appium:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc: AndroidMobileCapabilityType: missing chromedriverPort/chromedriverPorts
4 participants