Additional changes of the #473 #786
Conversation
- AuthenticatesByFinger was added to `io.appium.java_client.android` - Some improvements of the FingerPrintTest
|
@alizelzele You can take a look at this PR and review it too. |
| service = AppiumDriverLocalService.buildDefaultService(); | ||
| service.start(); | ||
|
|
||
| if (service == null || !service.isRunning()) { |
There was a problem hiding this comment.
service cannot be null here
There was a problem hiding this comment.
@mykola-mokhnach it was copied from BaseAndroidTest and for sure it can not be null here :)
| enterPasswordAndContinue(driver); | ||
| enterPasswordAndContinue(driver); | ||
| clickNext(driver); | ||
| driver.quit(); |
There was a problem hiding this comment.
I'd rather move driver create/quit into before/after each method
There was a problem hiding this comment.
@TikhomirovSergey I always get errors irrespective of API levels (23,25, 26) & UIA1/UIA2.
https://gist.github.com/SrinivasanTarget/416e82b0f13db0b237cc92a23a85cbf6
|
@SrinivasanTarget Did you try to grant app permissions in capabilities? |
|
@mykola-mokhnach I tried with |
|
@SrinivasanTarget Everything is ok for me. Could you try such emulator
@mykola-mokhnach I am going to make some changes soon. |
|
@TikhomirovSergey It works with above config. But not in API 25 & 26. |
|
@SrinivasanTarget since we are not using any test app and android changed its settings implementation on different APIs. I didn't find any other way to implement this test. |
|
@alizelzele @mykola-mokhnach @SrinivasanTarget |
|
@SrinivasanTarget Could you try to run the test with the latest change. It seems I made it working. |
| driver.fingerPrint(2); | ||
| try { | ||
| clickNext(driver); | ||
| driver.findElementById("com.android.settings:id/next_button").click(); |
There was a problem hiding this comment.
Yes. Will improve today.
| text.equals(androidElement.getText())).findFirst() | ||
| .orElseThrow(() -> | ||
| new NoSuchElementException(String.format("There is no element with the text '%s'", text))); | ||
| } |
There was a problem hiding this comment.
I was so used to localization testing that my mind automatically blocked using text to find an element :)
using text is much better and easier in this case 👍
|
@SrinivasanTarget The improvement has been done |
|
@SrinivasanTarget Is the test stable on your environment? |
|
yeaaayyy, finally 🎉 |
Change list
Additional changes of the #473
Types of changes
Details
io.appium.java_client.android