Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App upload via link #1287

Merged
merged 2 commits into from
Dec 18, 2023
Merged

App upload via link #1287

merged 2 commits into from
Dec 18, 2023

Conversation

SmitGala
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 30, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fc7f82d
Status: ✅  Deploy successful!
Preview URL: https://999b313a.irenestaging.pages.dev
Branch Preview URL: https://pd-929-app-upload-via-link.irenestaging.pages.dev

View logs

future-pirate-king
future-pirate-king requested changes Oct 30, 2023
View reviewed changes
app/adapters/upload-app-url.js Outdated Show resolved Hide resolved
app/components/upload-app/status/details/index.hbs Outdated Show resolved Hide resolved
app/components/upload-app/status/details/index.hbs Outdated Show resolved Hide resolved
app/components/upload-app/status/details/index.scss Outdated Show resolved Hide resolved
app/components/upload-app/status/details/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.hbs Outdated Show resolved Hide resolved
app/components/upload-app/status/index.hbs Outdated Show resolved Hide resolved
app/components/upload-app/status/index.hbs Outdated Show resolved Hide resolved
app/components/upload-app/status/index.hbs Outdated Show resolved Hide resolved
app/components/upload-app/status/index.hbs Outdated Show resolved Hide resolved
future-pirate-king
future-pirate-king requested changes Oct 31, 2023
View reviewed changes
app/components/upload-app/status/index.scss Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
app/components/upload-app/status/index.ts Outdated Show resolved Hide resolved
future-pirate-king
future-pirate-king requested changes Nov 12, 2023
View reviewed changes
app/components/file-details/summary/app-platform/index.hbs Outdated Show resolved Hide resolved
app/components/file-details/summary/index.hbs Outdated Show resolved Hide resolved
app/components/upload-app/status/details/index.ts Show resolved Hide resolved
app/components/upload-app/status/details/index.ts Show resolved Hide resolved
app/components/upload-app/status/details/index.ts Show resolved Hide resolved
app/models/submission.ts Outdated Show resolved Hide resolved
app/models/submission.ts Outdated Show resolved Hide resolved
app/services/configuration.ts Outdated Show resolved Hide resolved
app/styles/_color.scss Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
future-pirate-king
future-pirate-king requested changes Nov 16, 2023
View reviewed changes
app/components/file-details/summary/app-platform/index.hbs Outdated Show resolved Hide resolved
app/components/notifications-dropdown/index.hbs Outdated Show resolved Hide resolved
app/styles/_component-variables.scss Outdated Show resolved Hide resolved
Yibaebi
Yibaebi reviewed Nov 21, 2023
View reviewed changes
app/components/file-details/summary/index.hbs Show resolved Hide resolved
app/components/upload-app/status/details/index.ts Show resolved Hide resolved
app/components/upload-app/status/index.ts Show resolved Hide resolved
app/models/submission.ts Outdated Show resolved Hide resolved
app/services/upload-app.ts Outdated Show resolved Hide resolved
tests/integration/components/upload-app/index-test.js Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 18, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

26 New issues
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

@future-pirate-king future-pirate-king merged commit 018d73d into develop Dec 18, 2023
6 checks passed
@future-pirate-king future-pirate-king deleted the PD-929-app-upload-via-link branch December 18, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yibaebi Yibaebi Yibaebi left review comments

@future-pirate-king future-pirate-king future-pirate-king approved these changes

@Praseetha-KR Praseetha-KR Awaiting requested review from Praseetha-KR

@cosmosgenius cosmosgenius Awaiting requested review from cosmosgenius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SmitGala @future-pirate-king @Yibaebi