Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Monitoring UI Update #1331

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Store Monitoring UI Update #1331

merged 1 commit into from
Feb 19, 2024

Conversation

SmitGala
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: de88a86
Status: ✅  Deploy successful!
Preview URL: https://8f86c036.irenestaging.pages.dev
Branch Preview URL: https://pd-1062-store-monitoring-ui.irenestaging.pages.dev

View logs

@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 6cd56f4 to 62aa20f Compare January 24, 2024 05:03
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 62aa20f to c360263 Compare January 29, 2024 06:23
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from c360263 to e22ecf5 Compare January 31, 2024 12:32
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from e22ecf5 to a391207 Compare February 2, 2024 07:27
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from a391207 to 9de2e46 Compare February 5, 2024 07:23
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 9de2e46 to 776a9d0 Compare February 5, 2024 07:46
@future-pirate-king future-pirate-king changed the base branch from FE-9-Homepage-UI-Revamp to develop February 5, 2024 08:43
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 776a9d0 to b37e316 Compare February 5, 2024 10:54
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from b37e316 to e514e83 Compare February 5, 2024 11:11
future-pirate-king
future-pirate-king requested changes Feb 5, 2024
View reviewed changes
app/components/app-monitoring/settings/index.ts Outdated Show resolved Hide resolved
app/components/app-monitoring/settings/index.ts Outdated Show resolved Hide resolved
tests/acceptance/app-monitoring/settings-test.js Outdated Show resolved Hide resolved
tests/acceptance/app-monitoring/settings-test.js Outdated Show resolved Hide resolved
tests/acceptance/app-monitoring/settings-test.js Outdated Show resolved Hide resolved
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from e514e83 to 7c3a500 Compare February 5, 2024 14:51
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 7c3a500 to 4d829d6 Compare February 5, 2024 14:56
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 4d829d6 to 73b61a1 Compare February 5, 2024 15:12
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 73b61a1 to 4c616e1 Compare February 5, 2024 15:18
future-pirate-king
future-pirate-king requested changes Feb 6, 2024
View reviewed changes
tests/acceptance/app-monitoring/settings-test.js Outdated Show resolved Hide resolved
tests/acceptance/app-monitoring/settings-test.js Outdated Show resolved Hide resolved
app/components/app-monitoring/settings/index.ts Outdated Show resolved Hide resolved
app/components/app-monitoring/settings/index.ts Outdated Show resolved Hide resolved
@future-pirate-king future-pirate-king mentioned this pull request Feb 6, 2024
Merged
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from 4c616e1 to a7f587c Compare February 6, 2024 10:53
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from a7f587c to ebf460e Compare February 6, 2024 11:41
@SmitGala SmitGala force-pushed the PD-1062-Store-Monitoring-UI-Update branch from ebf460e to dae5efd Compare February 9, 2024 06:00
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
8.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Feb 19, 2024

Passing run #20 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge de88a86 into 3669be2...
Project: Irene Commit: 0164291044 ℹ️
Status: Passed Duration: 00:19 💡
Started: Feb 19, 2024 6:07 AM Ended: Feb 19, 2024 6:07 AM

Review all test suite changes for PR #1331 ↗︎

@future-pirate-king future-pirate-king merged commit 6a07ef0 into develop Feb 19, 2024
8 checks passed
@future-pirate-king future-pirate-king deleted the PD-1062-Store-Monitoring-UI-Update branch February 19, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@future-pirate-king future-pirate-king future-pirate-king approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SmitGala @future-pirate-king