Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add core deps to different build targets. #629

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Add core deps to different build targets. #629

merged 1 commit into from
Aug 5, 2024

Conversation

markblee
Copy link
Contributor

@markblee markblee commented Aug 5, 2024

No description provided.

@samos123
Copy link
Contributor

samos123 commented Aug 5, 2024

this would fix #628

@markblee markblee marked this pull request as ready for review August 5, 2024 19:49
@markblee markblee requested a review from ruomingp as a code owner August 5, 2024 19:49
@markblee markblee added this pull request to the merge queue Aug 5, 2024
Merged via the queue into apple:main with commit a80249e Aug 5, 2024
4 checks passed
@markblee markblee deleted the markblee/core branch August 5, 2024 22:53
@markblee markblee mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samos123 samos123 samos123 approved these changes

@ruomingp ruomingp ruomingp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markblee @samos123 @ruomingp