Revert 0c4280dcc59dd2a8c21f29ddf12f04a1e85c4141 #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 0c4280d attempted to avoid reclaiming of old memory when resized for cases where the memory maybe shared by multiple threads. However modifying a Buffer accross mulitiple threads may lead to visibility issues where the reference to the new array maybe visible before the memory is copied into the array, and in general requires external synchornization. Modificiations: - Revert the freeDirect(ByteBuffer) override introduced in 0c4280d Result: We can reclaim intermediate memory from resize operations again.
NiteshKant
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
0c4280d attempted to avoid reclaiming of old
memory when resized for cases where the memory maybe shared by multiple threads.
However modifying a Buffer accross mulitiple threads may lead to visibility
issues where the reference to the new array maybe visible before the memory is
copied into the array, and in general requires external synchornization.
Modificiations:
0c4280d
Result:
We can reclaim intermediate memory from resize operations again.