Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.0.3] Audit public functions and properties that could be inlinable #83

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

LucianoPAlmeida
Copy link
Contributor

@LucianoPAlmeida LucianoPAlmeida commented Feb 21, 2021

Tackle items Audit inlinability annotations throughout of #80

  • Make public methods and properties inlinable

Note: I didn't touch sortedPrefix file to avoid conflicts with renaming PR in progress =]
cc @natecook1000 @kylemacomber @timvermeulen

Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@LucianoPAlmeida
Copy link
Contributor Author

Reverted the part related to making base properties on lazy wrappers internal, as its better to do this in another PR :)

@natecook1000
Copy link
Member

Reverted the part related to making base properties on lazy wrappers internal, as its better to do this in another PR :)

This was my one note! 😆 Looks good otherwise — thanks, @LucianoPAlmeida!

@natecook1000 natecook1000 merged commit 914e626 into apple:main Feb 23, 2021
@natecook1000 natecook1000 mentioned this pull request Feb 23, 2021
6 tasks
@LucianoPAlmeida LucianoPAlmeida deleted the inline-all branch February 23, 2021 21:02
@LucianoPAlmeida
Copy link
Contributor Author

This was my one note! 😆 Looks good otherwise

Awesome, thanks Nate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants