Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install the Foundation toolchain module during the static swift build #391

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jmschonfeld
Copy link
Contributor

This updates the cmake build (specifically the single-module, foundation toolchain build section) to install the _FoundationCollections.a library for the static swift build (but not install it for the non-static build). This ensures the library is present in the static swift SDK in the toolchain (as needed) but not in the standard directory. The usage of this module is still guarded by the -allowable-client flag written into the swift module.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@jmschonfeld
Copy link
Contributor Author

The toolchain build at https://ci.swift.org/job/swift-PR-toolchain-Linux/873 has confirmed that this no longer poses an issue with the static swift build

@jmschonfeld jmschonfeld marked this pull request as ready for review June 18, 2024 21:51
@jmschonfeld jmschonfeld merged commit af8349c into apple:release/1.1 Jun 18, 2024
@jmschonfeld jmschonfeld deleted the cmake-install-static-lib branch June 18, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants