Skip to content

[4.2] SR-7195: JSONSerialization encodes Double differently on Darwin and Linux #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

[4.2] SR-7195: JSONSerialization encodes Double differently on Darwin and Linux #2024

merged 1 commit into from
Mar 20, 2019

Conversation

spevans
Copy link
Contributor

@spevans spevans commented Mar 20, 2019

  • Use .description property of numbers to encode as String
    instead of using CFNumberFormatter for Float/Double,
    and serialising integers explictly.

(cherry picked from commit 72e7bbd)

  • Add round-trip serialisation test case.

(cherry picked from commit ad620ff)

@spevans
SR-7195: JSONSerialization encodes Double differently on Darwin and L…
826b9f0 
…inux

- Use .description property of numbers to encode as String
  instead of using CFNumberFormatter for Float/Double,
  and serialising integers explictly.

(cherry picked from commit 72e7bbd)

- Add round-trip serialisation test case.

(cherry picked from commit ad620ff)
@spevans
Copy link
Contributor Author

spevans commented Mar 20, 2019

@swift-ci test

@spevans
Copy link
Contributor Author

spevans commented Mar 20, 2019

cc @weissi @kevints

@spevans
Copy link
Contributor Author

spevans commented Mar 20, 2019

@swift-ci test 4.2

1 similar comment
@spevans
Copy link
Contributor Author

spevans commented Mar 20, 2019

@swift-ci test 4.2

@spevans
Copy link
Contributor Author

spevans commented Mar 20, 2019

The failing Swift Test macOS Platform is the incorrect test suite, from using the test instead of test 4.2 command. This passed otherwise.

weissi
weissi approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@weissi weissi merged commit 3a40ed4 into swiftlang:swift-4.2-branch Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spevans @weissi