-act,fault #50 remove fault handling code and test #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Aug 28, 2019
| case .stop: fatalError("Illegal attempt to interpret message with .stop behavior! Actor should not be acting anymore. Behavior should have been canonicalized. This is a bug, please open a ticket.", file: file, line: line) | ||
| case .failed: fatalError("Illegal attempt to interpret message with .failed behavior! Actor should not be acting anymore. Behavior should have been canonicalized. This is a bug, please open a ticket.", file: file, line: line) | ||
| case .stop: | ||
| return .unhandled |
There was a problem hiding this comment.
This actually seems to happen when we're shutting down the system...
We need to check this independently, but semantics wise it is correct to say unhandled here I think 🤔
There was a problem hiding this comment.
It shouldn't really happen though, right? I'm curious what causes this.
There was a problem hiding this comment.
Yes, it shouldn't; Shutting down may be a bit weird but it still should not happen; I'll make a ticket
5 tasks
drexin
requested changes
Aug 28, 2019
| case .stop: fatalError("Illegal attempt to interpret message with .stop behavior! Actor should not be acting anymore. Behavior should have been canonicalized. This is a bug, please open a ticket.", file: file, line: line) | ||
| case .failed: fatalError("Illegal attempt to interpret message with .failed behavior! Actor should not be acting anymore. Behavior should have been canonicalized. This is a bug, please open a ticket.", file: file, line: line) | ||
| case .stop: | ||
| return .unhandled |
There was a problem hiding this comment.
It shouldn't really happen though, right? I'm curious what causes this.
|
Ok, this now aggresively removes all fault handling code as well as any tests. |
This was referenced Aug 29, 2019
drexin
approved these changes
Aug 29, 2019
ktoso
added a commit
that referenced
this pull request
Aug 31, 2019
* -act,fault #50 remove fault handling code and test * Remove all Fault handling code * disable some tests that rely on fault handling * -act,supervision COMPLETELY remove fault supervision code from mailbox * More mailbox removals due to lack of fault handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable and remove fault handling code.
Resolves #50
Motivation:
We are not sure about shipping the "leaking but surviving" mode, and hope to replace it some day with something serious.
In the meantime
ProcessIsolatedshall be the way to handle faults. Heavy but more correct and not leaking memory.We hope to some day get proper support for unwinding in Swift which would enable us to implement this properly, and safely.
Modifications:
Result:
The replacement for this mode is the heavy but correct
ProcessIsolatedmode until we get something better.