Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import TestMetrics from swift-metrics-extras #106

Merged
merged 3 commits into from Mar 18, 2022

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Jan 18, 2022

After a long chain of "originally developed in" (swift distributed actors -> swift cluster membership -> swift metrics extras) finally moving the test metrics to where they should belong, the metrics repo!

This set of types allows for testing metrics.
The backend can be used in tests to bootstrap and then get metrics of the right label/dimensions and write assertions against them.

TODO:

  • port the tests too (from actors, pretty sure we have some)

cc @fabianfett @tomerd

@ktoso
Copy link
Member Author

ktoso commented Jan 18, 2022

Resolves #107

Copy link
Member

@fabianfett fabianfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. The only issue I can see is the potential naming conflict, since we now have MetricsTestUtils in swift-metrics and swift-metrics-extras. But since adopters need to declare which package an imported library is comming from this shouldn't be an issue, right?

@tomerd
Copy link
Member

tomerd commented Jan 19, 2022

The only issue I can see is the potential naming conflict, since we now have MetricsTestUtils in swift-metrics and swift-metrics-extras. But since adopters need to declare which package an imported library is coming from this shouldn't be an issue, right?

I actually think this is a problem.. at least until https://forums.swift.org/t/se-0339-module-aliasing-for-disambiguation/54730 is in place

@ktoso
Copy link
Member Author

ktoso commented Feb 2, 2022

How about moving back to best name ever -- MetricsTestKit then? :-)

@fabianfett
Copy link
Member

MetricsTestKit it is!

@ktoso
Copy link
Member Author

ktoso commented Mar 18, 2022

@swift-server-bot test this please

1 similar comment
@ktoso
Copy link
Member Author

ktoso commented Mar 18, 2022

@swift-server-bot test this please

@ktoso
Copy link
Member Author

ktoso commented Mar 18, 2022

Merging since @fabianfett approved 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants