-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import TestMetrics from swift-metrics-extras #106
Conversation
f52cd72
to
b84f463
Compare
Resolves #107 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. The only issue I can see is the potential naming conflict, since we now have MetricsTestUtils
in swift-metrics
and swift-metrics-extras
. But since adopters need to declare which package an imported library is comming from this shouldn't be an issue, right?
I actually think this is a problem.. at least until https://forums.swift.org/t/se-0339-module-aliasing-for-disambiguation/54730 is in place |
How about moving back to best name ever -- MetricsTestKit then? :-) |
|
@swift-server-bot test this please |
1 similar comment
@swift-server-bot test this please |
959af59
to
aafbc61
Compare
Merging since @fabianfett approved 👍 |
After a long chain of "originally developed in" (swift distributed actors -> swift cluster membership -> swift metrics extras) finally moving the test metrics to where they should belong, the metrics repo!
This set of types allows for testing metrics.
The backend can be used in tests to bootstrap and then get metrics of the right label/dimensions and write assertions against them.
TODO:
cc @fabianfett @tomerd