Add initial support for discontiguous bit fields #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the bit field macros 'bits' argument to accept a list of bit ranges. The register macro uses this information to generate a bit field descriptor type conforming to either ContiguousBitField or DiscontiguousBitField. The public api for users remains unchanged. This commit doesn't introduce any diagnostics for overlapping bit fields within a discontiguous bit fields. A future commit will include those diagnostics as well as additional diagnostics for overlapping bit fields across fields in a register. In the future the implementation of bit field descriptors could be improved. At a high level we would introduce a BitField protocol with two requirements: least significant bit and most significant bit. We would then extend FixedWidthInteger with a subscript taking a variadic list of these fields. This change would allow us to remove the distinction between contiguous and discontiguous bit fields. In order to make this change we need variadic pack iteration to land and we need to be able to use variadic packs without using runtime metadata.
rauhul
added a commit
that referenced
this pull request
Oct 26, 2023
Adds a missing change from 'Add initial support for discontiguous bit fields (#10)' which makes the 'bits' argument to the various bit field macros variadic.
rauhul
added a commit
that referenced
this pull request
Oct 26, 2023
Adds a missing change from 'Add initial support for discontiguous bit fields (#10)' which makes the 'bits' argument to the various bit field macros variadic.
rauhul
added a commit
that referenced
this pull request
Nov 17, 2023
Updates the bit field macros 'bits' argument to accept a list of bit ranges. The register macro uses this information to generate a bit field descriptor type conforming to either ContiguousBitField or DiscontiguousBitField. The public api for users remains unchanged. This commit doesn't introduce any diagnostics for overlapping bit fields within a discontiguous bit fields. A future commit will include those diagnostics as well as additional diagnostics for overlapping bit fields across fields in a register. In the future the implementation of bit field descriptors could be improved. At a high level we would introduce a BitField protocol with two requirements: least significant bit and most significant bit. We would then extend FixedWidthInteger with a subscript taking a variadic list of these fields. This change would allow us to remove the distinction between contiguous and discontiguous bit fields. In order to make this change we need variadic pack iteration to land and we need to be able to use variadic packs without using runtime metadata.
rauhul
added a commit
that referenced
this pull request
Nov 17, 2023
Adds a missing change from 'Add initial support for discontiguous bit fields (#10)' which makes the 'bits' argument to the various bit field macros variadic.
rauhul
added a commit
that referenced
this pull request
Nov 17, 2023
Updates the bit field macros 'bits' argument to accept a list of bit ranges. The register macro uses this information to generate a bit field descriptor type conforming to either ContiguousBitField or DiscontiguousBitField. The public api for users remains unchanged. This commit doesn't introduce any diagnostics for overlapping bit fields within a discontiguous bit fields. A future commit will include those diagnostics as well as additional diagnostics for overlapping bit fields across fields in a register. In the future the implementation of bit field descriptors could be improved. At a high level we would introduce a BitField protocol with two requirements: least significant bit and most significant bit. We would then extend FixedWidthInteger with a subscript taking a variadic list of these fields. This change would allow us to remove the distinction between contiguous and discontiguous bit fields. In order to make this change we need variadic pack iteration to land and we need to be able to use variadic packs without using runtime metadata.
rauhul
added a commit
that referenced
this pull request
Nov 17, 2023
Adds a missing change from 'Add initial support for discontiguous bit fields (#10)' which makes the 'bits' argument to the various bit field macros variadic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the bit field macros 'bits' argument to accept a list of bit ranges. The register macro uses this information to generate a bit field descriptor type conforming to either ContiguousBitField or DiscontiguousBitField. The public api for users remains unchanged.
This commit doesn't introduce any diagnostics for overlapping bit fields within a discontiguous bit fields. A future commit will include those diagnostics as well as additional diagnostics for overlapping bit fields across fields in a register.
In the future the implementation of bit field descriptors could be improved. At a high level we would introduce a BitField protocol with two requirements: least significant bit and most significant bit. We would then extend FixedWidthInteger with a subscript taking a variadic list of these fields. This change would allow us to remove the distinction between contiguous and discontiguous bit fields. In order to make this change we need variadic pack iteration to land and we need to be able to use variadic packs without using runtime metadata.