Add @RegisterBank macros #2
Conversation
Adds a pair of macros used to define a bank of registers directly in Swift code called `@RegisterBank` and `@RegisterBank(offset:)`. Referred to as bank and offset macro respectively. The bank macro converts a struct defining the layout of nested registers and nested register banks into a reference type containing the base address of the structure. The offset macro converts stored properties into computed properties offset from the base address introduced by the bank macro. The bank and offset macros emit a number of diagnostics and fix-its to aid programmers. Adds a variety of test cases for each macro individually and both used in conjunction.
rauhul
requested review from
jckarter,
phausler,
kubamracek,
rokhinip and
ahoppen
|
|
||
| import SwiftSyntax | ||
|
|
||
| protocol HasIntroducerKeyword { |
There was a problem hiding this comment.
I think this would make sense as a trait in swift-syntax as well. Would you mind opening a PR for it or file an issue for it?
There was a problem hiding this comment.
It's not clear to me how to represent this in the swift-syntax trait system since the mapping from typeKeyword to introducerKeyword must be manually specified?
There was a problem hiding this comment.
It ought to be possible to protocol-ize it, I'd think. :)
There was a problem hiding this comment.
Clearly the requirement is able to be factored into a protocol, what isn't obvious is how to generate the mapping from each conformer to the protocol's introducerKeyword requirement using swift-syntax's Trait DSL.
Sources/MMIOMacros/SwiftSyntaxExtensions/HasModifiersDeclSyntax.swift
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Binding must have a type annotation. | ||
| guard let type = binding.typeAnnotation?.type else { |
There was a problem hiding this comment.
if we had some sort of #type(of:) that would emit a type at type resolution time would that alleviate this restriction? Observable ran into similar issues.
There was a problem hiding this comment.
So really I could drop a lot of these diagnostics. What I really want to assert is that the type of the stored property that the macro was attached to conforms to a particular protocol, but as you know thats not possible.
I added a bunch of diagnostics here to hopefully lead people in the right direction, but its not as fool proof as I would like.
There was a problem hiding this comment.
it does make me wonder if this is perhaps a job for property wrappers.
There was a problem hiding this comment.
I can't reach for self's unsafeAddress from a wrapper. Property wrappers always own their storage. (there's an escape hatch for classes, but that doesn't apply here)
| @@ -0,0 +1,14 @@ | |||
| { | |||
There was a problem hiding this comment.
probably don't want the resolved in here right?
There was a problem hiding this comment.
Maybe, I'm not sure how I feel about omitting it
Adds a pair of macros used to define a bank of registers directly in Swift code called `@RegisterBank` and `@RegisterBank(offset:)`. Referred to as bank and offset macro respectively. The bank macro converts a struct defining the layout of nested registers and nested register banks into a reference type containing the base address of the structure. The offset macro converts stored properties into computed properties offset from the base address introduced by the bank macro. The bank and offset macros emit a number of diagnostics and fix-its to aid programmers. Adds a variety of test cases for each macro individually and both used in conjunction.
Adds a pair of macros used to define a bank of registers directly in Swift code called `@RegisterBank` and `@RegisterBank(offset:)`. Referred to as bank and offset macro respectively. The bank macro converts a struct defining the layout of nested registers and nested register banks into a reference type containing the base address of the structure. The offset macro converts stored properties into computed properties offset from the base address introduced by the bank macro. The bank and offset macros emit a number of diagnostics and fix-its to aid programmers. Adds a variety of test cases for each macro individually and both used in conjunction.
Adds a pair of macros used to define a bank of registers directly in Swift code called
@RegisterBankand@RegisterBank(offset:). Referred to as bank and offset macro respectively.The bank macro converts a struct defining the layout of nested registers and nested register banks into a reference type containing the base address of the structure. The offset macro converts stored properties into computed properties offset from the base address introduced by the bank macro. The bank and offset macros emit a number of diagnostics and fix-its to aid programmers.
Adds a variety of test cases for each macro individually and both used in conjunction.