Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full example demonstrating the universal bootstrap #48

Merged
merged 1 commit into from
May 7, 2020

Conversation

weissi
Copy link
Member

@weissi weissi commented May 5, 2020

Motivation:

SwiftNIO now supports a universal bootstrapping mechanism. Unfortunately, it still requires some thought from the programmer to use it correctly which is why we should provide a full example.

Modifications:

Add an example imitating a simple HTTP library.

Result:

More examples.

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks like a really good demo to have. Nice one!

Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of small suggestions; looks awesome otherwise!

Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glbrntt glbrntt merged commit 8554684 into apple:master May 7, 2020
@weissi weissi deleted the jw-unibs-example branch May 7, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants