Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using vendored copy of zlib SwiftPM package rather than system copy of zlib. #30

Closed
satishbabariya opened this issue Mar 3, 2019 · 4 comments
Labels
kind/enhancement Improvements to existing feature.

Comments

@satishbabariya
Copy link

Discussion on which solution is a better solution,

  1. vendored copy of zlib SwiftPM package
  2. system copy of zlib.

as @Lukasa proposed using a separate SwiftPM package that is appropriately versioned and then add an appropriate dependency on it.
rather than integrating vendored copy of zlib into the swift-nio directly (-1 form @Lukasa)

if swift-nio 2.0 goes with the vendored copy of zlib SwiftPM package, then the swift-nio adopters can use same SwiftPM package.

@Lukasa
Copy link
Contributor

Lukasa commented Mar 3, 2019

To be clear, I am also opposed to depending on a SwiftPM zlib package. I think the most interesting alternative would be a well-maintained Swift implementation of gzip and deflate.

Until that time I think I’d rather use the system zlib.

@weissi
Copy link
Member

weissi commented Mar 4, 2019

@satishbabariya so we will actually move the HTTP compressor (which requires this dependency) into swift-nio-extras

@weissi weissi transferred this issue from apple/swift-nio Mar 4, 2019
@satishbabariya
Copy link
Author

Yeah, that would be great also.

@weissi weissi added the kind/enhancement Improvements to existing feature. label Mar 26, 2019
@firecrackerz
Copy link

@weissi there are some pure swift implementation i found, it's worth looking into.
https://github.com/tsolomko/SWCompression

It also works both on Apple platforms and Linux.

All features are listed in the tables below.
"TBD" means that feature is planned but not implemented (yet).

Deflate BZip2 LZMA/LZMA2
Decompression
Compression TBD
Zlib GZip XZ ZIP TAR 7-Zip
Read
Write TBD TBD TBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements to existing feature.
Projects
None yet
Development

No branches or pull requests

4 participants