Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command encoder #102

Merged
merged 1 commit into from
May 18, 2020
Merged

command encoder #102

merged 1 commit into from
May 18, 2020

Conversation

weissi
Copy link
Member

@weissi weissi commented Apr 27, 2020

No description provided.

@weissi
Copy link
Member Author

weissi commented May 13, 2020

@Davidde94 this is getting pretty much ready. Might be worth having a first look.

@weissi weissi requested a review from Davidde94 May 13, 2020 16:11
@weissi weissi marked this pull request as ready for review May 18, 2020 10:23
Copy link
Collaborator

@Davidde94 Davidde94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, potential question about what continuations should look like

Sources/NIOIMAP/Coders/IMAPClientHandler.swift Outdated Show resolved Hide resolved
Sources/NIOIMAP/Coders/IMAPServerHandler.swift Outdated Show resolved Hide resolved
Sources/NIOIMAP/NIOIMAP.swift Show resolved Hide resolved
Sources/NIOIMAPCore/EncodeBuffer.swift Outdated Show resolved Hide resolved
Sources/NIOIMAPCore/EncodeBuffer.swift Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the decoder & encoder into one ChannelHandler that properly wires everything up
2 participants