Rename the EndToEndTests in the WebSocket project to WebSocketServerE…

…ndToEndTests. (#1032) Motivation: To make the web socket server end to end tests class more descriptive. This will allow ‘WebSocketClientEndToEndTests’ or other end to end tests to be added at a later date. Modifications: Renames the class and filename for ‘EndToEndTests’ to ‘WebSocketServerEndToEndTests’ Result: The nomenclature now allow for other end to end tests to be added.
apple · Jun 12, 2019 · f508435 · f508435
1 parent dfe4318
commit f508435
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Tests/LinuxMain.swift b/Tests/LinuxMain.swift
@@ -52,7 +52,6 @@ import XCTest
          testCase(EchoServerClientTest.allTests),
          testCase(EmbeddedChannelTest.allTests),
          testCase(EmbeddedEventLoopTest.allTests),
-         testCase(EndToEndTests.allTests),
          testCase(EventCounterHandlerTest.allTests),
          testCase(EventLoopFutureTest.allTests),
          testCase(EventLoopTest.allTests),
@@ -93,5 +92,6 @@ import XCTest
          testCase(UtilitiesTest.allTests),
          testCase(WebSocketFrameDecoderTest.allTests),
          testCase(WebSocketFrameEncoderTest.allTests),
+         testCase(WebSocketServerEndToEndTests.allTests),
     ])
 #endif
diff --git a/...WebSocketTests/EndToEndTests+XCTest.swift → ...WebSocketServerEndToEndTests+XCTest.swift b/...WebSocketTests/EndToEndTests+XCTest.swift → ...WebSocketServerEndToEndTests+XCTest.swift
@@ -12,7 +12,7 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// EndToEndTests+XCTest.swift
+// WebSocketServerEndToEndTests+XCTest.swift
 //
 import XCTest
 
@@ -22,9 +22,9 @@ import XCTest
 /// Do NOT edit this file directly as it will be regenerated automatically when needed.
 ///
 
-extension EndToEndTests {
+extension WebSocketServerEndToEndTests {
 
-   static var allTests : [(String, (EndToEndTests) -> () throws -> Void)] {
+   static var allTests : [(String, (WebSocketServerEndToEndTests) -> () throws -> Void)] {
       return [
                 ("testBasicUpgradeDance", testBasicUpgradeDance),
                 ("testUpgradeWithProtocolName", testUpgradeWithProtocolName),

diff --git a/Tests/NIOWebSocketTests/EndToEndTests.swift → ...tTests/WebSocketServerEndToEndTests.swift b/Tests/NIOWebSocketTests/EndToEndTests.swift → ...tTests/WebSocketServerEndToEndTests.swift
@@ -113,7 +113,7 @@ private class WebSocketRecorderHandler: ChannelInboundHandler {
     }
 }
 
-class EndToEndTests: XCTestCase {
+class WebSocketServerEndToEndTests: XCTestCase {
     func createTestFixtures(upgraders: [NIOWebSocketServerUpgrader]) -> (loop: EmbeddedEventLoop, serverChannel: EmbeddedChannel, clientChannel: EmbeddedChannel) {
         let loop = EmbeddedEventLoop()
         let serverChannel = EmbeddedChannel(loop: loop)