Skip to content
Permalink
Browse files

Rename the EndToEndTests in the WebSocket project to WebSocketServerE…

…ndToEndTests. (#1032)

Motivation:

To make the web socket server end to end tests class more descriptive.
This will allow ‘WebSocketClientEndToEndTests’ or other end to end tests to be added at a later date.

Modifications:

Renames the class and filename for ‘EndToEndTests’ to ‘WebSocketServerEndToEndTests’

Result:

The nomenclature now allow for other end to end tests to be added.
  • Loading branch information...
tigerpixel authored and Lukasa committed Jun 12, 2019
1 parent dfe4318 commit f5084352c6d18221aa26a7f6a3e2ef4fef551706
@@ -52,7 +52,6 @@ import XCTest
testCase(EchoServerClientTest.allTests),
testCase(EmbeddedChannelTest.allTests),
testCase(EmbeddedEventLoopTest.allTests),
testCase(EndToEndTests.allTests),
testCase(EventCounterHandlerTest.allTests),
testCase(EventLoopFutureTest.allTests),
testCase(EventLoopTest.allTests),
@@ -93,5 +92,6 @@ import XCTest
testCase(UtilitiesTest.allTests),
testCase(WebSocketFrameDecoderTest.allTests),
testCase(WebSocketFrameEncoderTest.allTests),
testCase(WebSocketServerEndToEndTests.allTests),
])
#endif
@@ -12,7 +12,7 @@
//
//===----------------------------------------------------------------------===//
//
// EndToEndTests+XCTest.swift
// WebSocketServerEndToEndTests+XCTest.swift
//
import XCTest

@@ -22,9 +22,9 @@ import XCTest
/// Do NOT edit this file directly as it will be regenerated automatically when needed.
///
extension EndToEndTests {
extension WebSocketServerEndToEndTests {

static var allTests : [(String, (EndToEndTests) -> () throws -> Void)] {
static var allTests : [(String, (WebSocketServerEndToEndTests) -> () throws -> Void)] {
return [
("testBasicUpgradeDance", testBasicUpgradeDance),
("testUpgradeWithProtocolName", testUpgradeWithProtocolName),
@@ -113,7 +113,7 @@ private class WebSocketRecorderHandler: ChannelInboundHandler {
}
}

class EndToEndTests: XCTestCase {
class WebSocketServerEndToEndTests: XCTestCase {
func createTestFixtures(upgraders: [NIOWebSocketServerUpgrader]) -> (loop: EmbeddedEventLoop, serverChannel: EmbeddedChannel, clientChannel: EmbeddedChannel) {
let loop = EmbeddedEventLoop()
let serverChannel = EmbeddedChannel(loop: loop)

0 comments on commit f508435

Please sign in to comment.
You can’t perform that action at this time.