Missing remoteAddress in ChatServer (Crash)

[ezfe]

Expected behavior

When the ChatClient sends a message, other clients see

(##remoteAddress##) - ##message##

Actual behavior

The ChatServer force-unwraps the remoteAddress field, encountering nil, and crashes.

Steps to reproduce

1. Run ChatServer
2. Run ChatClient (once is all that's needed to demonstrate crash, twice for full set up)
3. Send message by typing in ChatClient and pressing enter
4. ChatServer unexpectedly encounters nil here:

   swift-nio/Sources/NIOChatServer/main.swift

   Line 60 in 2c1d993

   buffer.write(string: "(\(ctx.channel.remoteAddress!)) - ")

Workaround

Modifying the above line referenced in part 4 to the following produces what appears to be expected behavior. However, I am unclear as to the difference between ctx.channel.remoteAddress and ctx.remoteAddress.

if let remoteAddress = ctx.remoteAddress {
    buffer.write(string: "(\(remoteAddress)) - ")
} else {
    buffer.write(string: "(no address) - ")
}

If possible, minimal yet complete reproducer code (or URL to code)

Provided ChatServer and ChatClient exhibit this behavior

SwiftNIO version/commit hash

2c1d993 (latest as this issue)

Swift & OS version (output of swift --version && uname -a)

Apple Swift version 4.0.3 (swiftlang-900.0.74.1 clang-900.0.39.2)
Target: x86_64-apple-macosx10.9
Darwin Ezekiels-MacBook-Pro-133.local 17.5.0 Darwin Kernel Version 17.5.0: Sun Feb 11 23:54:24 PST 2018; root:xnu-4570.50.279~25/RELEASE_X86_64 x86_64

[normanmaurer]

Will have a look

…

Am 04.03.2018 um 11:41 schrieb Ezekiel Elin ***@***.***>: Expected behavior When the ChatClient sends a message, other clients see (##remoteAddress##) - ##message## Actual behavior The ChatServer force-unwraps the remoteAddress field, encountering nil, and crashes. Steps to reproduce Run ChatServer Run ChatClient (once is all that's needed to demonstrate crash, twice for full set up) Send message by typing in ChatClient and pressing enter ChatServer unexpectedly encounters nil here: https://github.com/apple/swift-nio/blob/2c1d993978c97f286ae5e8f0fe4285bd47030a26/Sources/NIOChatServer/main.swift#L60 If possible, minimal yet complete reproducer code (or URL to code) Provided ChatServer and ChatClient exhibit this behavior SwiftNIO version/commit hash 2c1d993 (latest as this issue) Swift & OS version (output of swift --version && uname -a) Apple Swift version 4.0.3 (swiftlang-900.0.74.1 clang-900.0.39.2) Target: x86_64-apple-macosx10.9 Darwin Ezekiels-MacBook-Pro-133.local 17.5.0 Darwin Kernel Version 17.5.0: Sun Feb 11 23:54:24 PST 2018; root:xnu-4570.50.279~25/RELEASE_X86_64 x86_64 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[normanmaurer]

@ezfe hmm I can not reproduce it :( The remoteAddress should never be nil when channelRead is called.

[normanmaurer]

@ezfe ah never mind... I did execute the wrong example :(

[normanmaurer]

@ezfe this should be fixed by #98 ... Please check

[ezfe]

@normanmaurer I've confirmed that this resolves the issue. You may close this issue when appropriate.

[Lukasa]

Resolved by #98.