Correctly update cached addresses for accepted Channels. #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We missed to correctly update the cached remote and local addresses for accepted Channels. Because of this localAddress and remoteAddr always returned nil. Modifications: - Update cached addresses when constructing SocketChannel from existing Socket. - Add testcase Result: Fixes [apple#97].
|
Also @ezfe |
normanmaurer
added
bug
Lukasa
approved these changes
Mar 5, 2018
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
Motivation: RFC 7540 requires that compliant specifications emit errors if content-length has been incorrectly set. We should have this behaviour by default, though we should allow it to be disabled if necessary. Modifications: - Added content-length checking. - Added flag to disable content-length checking. Result: Better RFC 7540 compliance.
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Feb 3, 2024
Motivation: It's useful to know the overhead we could be adding by including the PCAP handler. Modifications: Add a new executable based on the NIO performance testing executable. Result: There is a new executable which runs a short test of sending and receiving data through the HTTP/1 handler using multiple eventloops and showing three options. 1) Vanilla 2) With in memory PCAP never written to disk 3) With a disk based PCAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We missed to correctly update the cached remote and local addresses for accepted Channels. Because of this localAddress and remoteAddr always returned nil.
Modifications:
Result:
Fixes [#97].