fix EVFILT_EXCEPT loop if autoRead is off on Darwin #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-fix-evfilt-except-loop
branch
from
2921167
to
3dbd2b3
Compare
Lukasa
approved these changes
Dec 14, 2019
There was a problem hiding this comment.
This LGTM. I’ll let @normanmaurer review as well, but I’m fine with this patch as-is.
normanmaurer
requested changes
Dec 16, 2019
glbrntt
approved these changes
Dec 16, 2019
weissi
force-pushed
the
jw-fix-evfilt-except-loop
branch
2 times, most recently
from
f2c96a9
to
5fec5ef
Compare
normanmaurer
approved these changes
Dec 16, 2019
Motivation: Due to rdar://53656794, we sometimes (especially on UNIX Domain Sockets) see EVFILT_EXCEPT firing when data is available to read depite the fact that we're setting the low watermark to CInt.max. This means that EVFILT_EXCEPT becomes essentially unusable. Modifications: - Don't use EVFILT_EXCEPT on Darwin - We lose early EOF delivery on Darwin Result: Fewer possibilities of a spin loop on Darwin.
weissi
force-pushed
the
jw-fix-evfilt-except-loop
branch
from
5fec5ef
to
9ac6fdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Due to rdar://53656794, we sometimes (especially on UNIX Domain Sockets)
see EVFILT_EXCEPT firing when data is available to read depite the fact
that we're setting the low watermark to CInt.max. This means that
EVFILT_EXCEPT becomes essentially unusable.
Modifications:
Result:
Fewer possibilities of a spin loop on Darwin.