Remove typeCheckExpressionShallow() #16235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
kill-shallow-checking
branch
from
917d734 to
e164ed2
Compare
xedin
reviewed
Apr 28, 2018
|
Nice cleanup! |
slavapestov
force-pushed
the
kill-shallow-checking
branch
from
e164ed2 to
7bfe081
Compare
…CheckExpressionShallow() Unfortunately, the new implementation is more complex for three reasons: - SubstitutionMap -vs- SubstitutionList is awkward to work with. - CallExpr takes a single TupleExpr argument, not a list of arguments. - The interpolation protocol has a weird behavior. The type checker would pick more specific concrete overloads of init(stringInterpolationSegment:) on String, even though they're not protocol requirements, and we have tests that rely on this behavior. The first two will be addressed eventually. The latter is contingent on a redesign of the whole interpolation protocol, which would be a nice thing to have before ABI stability.
slavapestov
force-pushed
the
kill-shallow-checking
branch
from
7bfe081 to
3ff0ab9
Compare
|
I’ve merged everything here except for the last usage which was in string interpolation. That still needs a bit of work to fix a diagnostics regression. |
|
@slavapestov Is this worth keeping open until you take a look at the string interpolation usage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.