Skip to content

Conversation

eaplatanios
Copy link

Copy link
Contributor

@rxwei rxwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To be merged after tensorflow/swift-apis#137.

@eaplatanios eaplatanios changed the title Removed the TF bindings copy from the CMakeLists file. [TF] Removed the TF bindings copy from the CMakeLists file. May 28, 2019
@eaplatanios
Copy link
Author

@rxwei How can I remove the swift-bindings repo fetching from the update-checkouts script? Should I just remove the corresponding lines from the json config file?

@rxwei
Copy link
Contributor

rxwei commented May 28, 2019

Yes, you can search for all occurrences of swift-bindings and remove their corresponding lines.

@eaplatanios
Copy link
Author

I removed all such references in the last commit.

@burmako burmako added the tensorflow This is for "tensorflow" branch PRs. label May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tensorflow This is for "tensorflow" branch PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants