Fixes [SR-78] swift compiler seg fault #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a segmentation fault where the IRGen module would crash when a generic (empty) struct was part of the source code because it tried to call std::next on an end iterator.
Updates to check for empty instead of checking iterator at end() for more readability.
|
@jckarter: can you review this? |
|
As the return value for this new use case (when the iterator is exhausted) is the same as when there are multiple stored properties, I would handle these in the same code path - more specifically: the only special case here is when there is a single stored property and everything else should use the main code path. |
Refactored the code so that there is only a single branch for when there is one stored property and the rest return a SILType() as per @simonmpilkington suggestion.
| } | ||
|
|
||
| struct Bar { | ||
| } |
|
LGTM. Add the missing newline like @blackrain suggested and I'll accept. |
|
@jckarter I added the newline. |
|
Perfect. Thanks @manavgabhawala! |
jckarter
added a commit
that referenced
this pull request
Dec 7, 2015
Fixes [SR-78] swift compiler seg fault
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Reapply "Fix compilation warnings in extended test suite".
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Fix builder factory to handle Swift version 4.2 correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SR-78 swift compiler segmentation fault. The IRGen module would crash when a generic (empty) struct was part of the source code because it tried to call std::next on an end iterator, adds in a guard to prevent against that and also adds a test case to add in this check.
Added test case that caused the old compiler to crash (I'm not sure if this is the right way to integrate it in the testing suite).