PS4 support

[compnerd]

What's in this pull request?

Resolved bug number: (SR-)

---

Before merging this pull request to apple/swift repository:

• Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform	Comment
All supported platforms	@swift-ci Please smoke test
All supported platforms	@swift-ci Please smoke test and merge
OS X platform	@swift-ci Please smoke test OS X platform
Linux platform	@swift-ci Please smoke test Linux platform

Validation Testing

Platform	Comment
All supported platforms	@swift-ci Please test
All supported platforms	@swift-ci Please test and merge
OS X platform	@swift-ci Please test OS X platform
OS X platform	@swift-ci Please benchmark
Linux platform	@swift-ci Please test Linux platform

Lint Testing

Language	Comment
Python	@swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

[jrose-apple]

cc @gribozavr, who's shepherded most new platforms.

How do PS4 version numbers work? It does seem to make sense that PS3 and PS4 are completely separate OSs, but…

[gribozavr]

Please add two tests like ./test/Parse/ConditionalCompilation/armAndroidTarget.swift and ./validation-test/StdlibUnittest/Android.swift.

I think every PS* platform should be treated as a separate target; for the existing platforms we know that every PS* target runs a unique OS, and it is ABI-incompatible and probably ISA-incompatible to every other PS* target. Even if the new one can run the programs for the previous one, it is typically an emulation mode that for all compilation concerns looks like the previous environment.

[gribozavr]

There should be no space before ":".

[compnerd]

Actually, lets wait for #3218 so that I can rebase on that and fix the linker directive handling. But, Ive added the test, any other review comments would be appreciated so that I can fix it up in one go.

[gribozavr]

@swift-ci Please test and merge

[gribozavr]

@compnerd Please take a look at the CI issues:

/home/buildnode/jenkins/workspace/swift-PR-Linux/swift/validation-test/StdlibUnittest/PS4.swift:7:24: error: type 'OSVersion' has no member 'PS4'

[gribozavr]

@swift-ci Please test and merge

[gribozavr]

@compnerd

/Users/buildnode/jenkins/workspace/swift-PR-osx/swift/stdlib/private/StdlibUnittest/StdlibUnittest.swift.gyb:1616:35: error: use of unresolved identifier 'reasaon'
      return "ps4Any(*, reason: \(reasaon))"
                                  ^~~~~~~
/Users/buildnode/jenkins/workspace/swift-PR-osx/swift/stdlib/private/StdlibUnittest/StdlibUnittest.swift.gyb:1615:30: note: did you mean 'reason'?
    case .ps4Any(reason: let reason):

[compnerd]

The test needs to be fixed, and I believe I need to hunt down one more issue in the linker option emission for PS4 work to be ready to merge.

[gribozavr]

@compnerd Sounds good. Just @-mention me when you are ready.

[compnerd]

@swift-ci Please test

[compnerd]

@gribozavr I think that all the swift side of things are complete.

[compnerd]

@gribozavr if nothing else remains to be addressed, I think this can be merged.

[gribozavr]

This matches what Clang does in its PS4TargetCodeGenInfo, so LGTM.

[gribozavr]

@swift-ci Please test and merge

[CodaFi]

@compnerd Do you know how the PS4 represents process arguments?